[webkit-reviews] review granted: [Bug 173371] Build WebKit with High Sierra (Seed 1) : [Attachment 312924] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Jonathan Bedard <jbedard at apple.com>'s
request for review:
Bug 173371: Build WebKit with High Sierra (Seed 1)
https://bugs.webkit.org/show_bug.cgi?id=173371

Attachment 312924: Patch

https://bugs.webkit.org/attachment.cgi?id=312924&action=review




--- Comment #12 from Andy Estes <aestes at apple.com> ---
Comment on attachment 312924
  --> https://bugs.webkit.org/attachment.cgi?id=312924
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312924&action=review

> Source/WebCore/platform/spi/cocoa/AVKitSPI.h:241
> +- (id)initWithTitle:(nonnull NSString *)title
type:(AVTouchBarMediaSelectionOptionType)type;

instancetype, not id

> Source/WebCore/platform/spi/cocoa/PassKitSPI.h:265
> +- (_Nonnull instancetype)initWithStatus:(PKPaymentAuthorizationStatus)status
errors:(nullable NSArray<NSError *> *)errors;

I don't think the _Nonnull is right. In general, Objective-C initializers can
return nil, and I don't see this annotation in the system header.

> Source/WebCore/platform/spi/cocoa/PassKitSPI.h:270
> +- (_Nonnull instancetype)initWithPaymentSummaryItems:(nonnull
NSArray<PKPaymentSummaryItem *> *)paymentSummaryItems;

Ditto.

> Source/WebCore/platform/spi/cocoa/PassKitSPI.h:273
> + at interface PKPaymentRequestShippingContactUpdate

PKPaymentRequestShippingContactUpdate inherits from PKPaymentRequestUpdate.

> Source/WebCore/platform/spi/cocoa/PassKitSPI.h:275
> +- (_Nonnull instancetype)initWithPaymentSummaryItems:(nonnull
NSArray<PKPaymentSummaryItem *> *)summaryItems shippingMethods:(nonnull
NSArray<PKShippingMethod *> *)shippingMethods;
> +- (_Nonnull instancetype)initWithErrors:(nullable NSArray<NSError *>
*)errors paymentSummaryItems:(nonnull NSArray<PKPaymentSummaryItem *>
*)summaryItems shippingMethods:(nonnull NSArray<PKShippingMethod *>
*)shippingMethods;

Ditto about _Nonnull.

> Source/WebCore/platform/spi/cocoa/PassKitSPI.h:295
> +- (void)setRequiredShippingContactFields:(nonnull NSSet*)
contactInformation;
> +- (void)setRequiredBillingContactFields:(nonnull NSSet*) contactInformation;

No space between the argument type and name.