[webkit-reviews] review denied: [Bug 173298] Disable asynchronous image decoding for server push and streaming over HTTP contents : [Attachment 312741] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 173298: Disable asynchronous image decoding for server push and streaming
over HTTP contents
https://bugs.webkit.org/show_bug.cgi?id=173298

Attachment 312741: Patch

https://bugs.webkit.org/attachment.cgi?id=312741&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 312741
  --> https://bugs.webkit.org/attachment.cgi?id=312741
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312741&action=review

Is there a way we can keep the older image around for longer in this case,
rather than falling back to sync decoding?

> Source/WebCore/rendering/RenderElement.cpp:2207
> +    if
(frame().loader().activeDocumentLoader()->isLoadingMultipartContent())

Is this right? You're assuming that the image is the main resource of that
loader, but I don't think that's valid. Maybe this is an image in some kind of
multipart text/html?