[webkit-reviews] review granted: [Bug 173342] Add SPI for immediate injection of user scripts : [Attachment 312904] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 173342: Add SPI for immediate injection of user scripts
https://bugs.webkit.org/show_bug.cgi?id=173342

Attachment 312904: Patch

https://bugs.webkit.org/attachment.cgi?id=312904&action=review




--- Comment #8 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 312904
  --> https://bugs.webkit.org/attachment.cgi?id=312904
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312904&action=review

r+ with one change (and green bots)

> Source/WebCore/page/Frame.cpp:721
> +    if (script.injectedFrames() == InjectInTopFrameOnly && ownerElement())
> +	   return;

Checking ownerElement() is not a valid check for main-frameness

Use !isMainFrame() instead.