[webkit-reviews] review granted: [Bug 173374] WKContentViewEditingActions API test always fails : [Attachment 312907] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 173374: WKContentViewEditingActions API test always fails
https://bugs.webkit.org/show_bug.cgi?id=173374

Attachment 312907: Patch

https://bugs.webkit.org/attachment.cgi?id=312907&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 312907
  --> https://bugs.webkit.org/attachment.cgi?id=312907
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312907&action=review

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:70
> +	       if ([[[UIPasteboard generalPasteboard] string]
isEqualToString:@"Hello world"])

Nit - could we make this always set done = true here, and then check that
[[[UIPasteboard generalPasteboard] string] isEqualToString:@"Hello world"]
after TestWebKitAPI::Util::run(&done) using EXPECT_WK_STREQ? This way, if the
strings don't match, it'll print out the expected vs. observed values instead
of timing out.