[webkit-reviews] review granted: [Bug 173367] WKErrorGetErrorCode should not return the API::Error enum values directly : [Attachment 312891] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 173367: WKErrorGetErrorCode should not return the API::Error enum values
directly
https://bugs.webkit.org/show_bug.cgi?id=173367

Attachment 312891: Patch

https://bugs.webkit.org/attachment.cgi?id=312891&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 312891
  --> https://bugs.webkit.org/attachment.cgi?id=312891
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312891&action=review

> Source/WebKit2/Shared/API/c/WKErrorRef.cpp:79
> +    default:
> +	   break;

Do we need this default?  If we are switching on enum values, a default would
prevent us from finding the bug of missing one of the enum values.  Let's
remove the default if we can.