[webkit-reviews] review granted: [Bug 173362] Add API::InjectedBundle::ResourceLoadClient : [Attachment 312884] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 173362: Add API::InjectedBundle::ResourceLoadClient
https://bugs.webkit.org/show_bug.cgi?id=173362

Attachment 312884: Patch

https://bugs.webkit.org/attachment.cgi?id=312884&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 312884
  --> https://bugs.webkit.org/attachment.cgi?id=312884
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312884&action=review

>
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserConte
xtController.mm:336
> -    page.initializeInjectedBundleResourceLoadClient(&client.base);
> +    WKBundlePageSetResourceLoadClient(toAPI(&page), &client.base);

I'm not sure about this change.  From API objects I think we want to call C++
methods, not use the C API.

>
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserConte
xtController.mm:353
> -	   _page->initializeInjectedBundleResourceLoadClient(nullptr);
> +	   WKBundlePageSetResourceLoadClient(toAPI(_page.get()), nullptr);

ditto