[webkit-reviews] review granted: [Bug 173361] [Win] DRT should not use disk cache. : [Attachment 312883] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 14 07:37:20 PDT 2017
Darin Adler <darin at apple.com> has granted Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 173361: [Win] DRT should not use disk cache.
https://bugs.webkit.org/show_bug.cgi?id=173361
Attachment 312883: Patch
https://bugs.webkit.org/attachment.cgi?id=312883&action=review
--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 312883
--> https://bugs.webkit.org/attachment.cgi?id=312883
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=312883&action=review
> Tools/DumpRenderTree/win/DumpRenderTree.cpp:1469
> + RetainPtr<CFURLCacheRef> newCache =
adoptCF(CFURLCacheCreate(kCFAllocatorDefault, 1024 * 1024, 0, nullptr));
I suggest using auto here, or just putting this inside the function call.
More information about the webkit-reviews
mailing list