[webkit-reviews] review granted: [Bug 173355] [GTK] Use API::InjectedBundle::EditorClient in WebKitWebEditor : [Attachment 312869] Patch

[bugzilla-daemon at webkit.org]

Zan Dobersek <zan at falconsigh.net> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 173355: [GTK] Use API::InjectedBundle::EditorClient in WebKitWebEditor
https://bugs.webkit.org/show_bug.cgi?id=173355

Attachment 312869: Patch

https://bugs.webkit.org/attachment.cgi?id=312869&action=review




--- Comment #2 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 312869
  --> https://bugs.webkit.org/attachment.cgi?id=312869
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312869&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebEditor.cpp:85
> +    void didChangeSelection(WebPage&, StringImpl* /*notificationName*/)
override

Consider UNUSED_PARAM(notificationName), or just not listing the argument name.