[webkit-reviews] review granted: [Bug 173319] Configure screen scale for running layout tests on plus devices : [Attachment 312827] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 173319: Configure screen scale for running layout tests on plus devices
https://bugs.webkit.org/show_bug.cgi?id=173319

Attachment 312827: Patch

https://bugs.webkit.org/attachment.cgi?id=312827&action=review




--- Comment #17 from Tim Horton <thorton at apple.com> ---
Comment on attachment 312827
  --> https://bugs.webkit.org/attachment.cgi?id=312827
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312827&action=review

> Source/WebKit2/Platform/spi/ios/UIKitSPI.h:216
> +#ifndef UI_KEYBOARD
> +#define UI_KEYBOARD 1

This should probably be more specifically WebKitty so there's no chance for
conflicts. We should probably move things around so we don't need this, but
that can happen later, maybe leave a fixme? Unless perhaps someone else has an
idea?