[webkit-reviews] review granted: [Bug 173330] Synchronous media query callbacks on nested frames could produced a detached FrameView. : [Attachment 312812] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 173330: Synchronous media query callbacks on nested frames could produced a
detached FrameView.
https://bugs.webkit.org/show_bug.cgi?id=173330

Attachment 312812: Patch

https://bugs.webkit.org/attachment.cgi?id=312812&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 312812
  --> https://bugs.webkit.org/attachment.cgi?id=312812
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312812&action=review

> Source/WebCore/page/FrameView.cpp:1522
> +	   // FIXME: Firing media query callbacks synchronously on nested
frames could produced a detached FrameView here (webkit.org/b/173329).

I would mention that a media query listener could trigger a navigation.