[webkit-reviews] review granted: [Bug 173299] Include PID in some UIProcess-side release logging that relates to a particular WebProcess : [Attachment 312742] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 13 13:55:22 PDT 2017


Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 173299: Include PID in some UIProcess-side release logging that relates to
a particular WebProcess
https://bugs.webkit.org/show_bug.cgi?id=173299

Attachment 312742: Patch

https://bugs.webkit.org/attachment.cgi?id=312742&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 312742
  --> https://bugs.webkit.org/attachment.cgi?id=312742
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312742&action=review

> Source/WebKit2/UIProcess/WebProcessProxy.cpp:1217
> +    RELEASE_LOG_ERROR(PerformanceLogging, "%p -
WebProcessProxy::didExceedActiveMemoryLimit() Terminating WebProcess with pid
%d that has exceeded the active memory limit", this, processIdentifier());

Can we be consist and use (pid: %d)?


More information about the webkit-reviews mailing list