[webkit-reviews] review granted: [Bug 173151] [GTK] Use API::GeolocationProvider in WebKitGeolocationProvider : [Attachment 312425] Patch

[bugzilla-daemon at webkit.org]

Zan Dobersek <zan at falconsigh.net> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 173151: [GTK] Use API::GeolocationProvider in WebKitGeolocationProvider
https://bugs.webkit.org/show_bug.cgi?id=173151

Attachment 312425: Patch

https://bugs.webkit.org/attachment.cgi?id=312425&action=review




--- Comment #3 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 312425
  --> https://bugs.webkit.org/attachment.cgi?id=312425
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312425&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationProvider.cpp:35
>  #if ENABLE(GEOLOCATION)

These normally go after the "config.h" and main header inclusion.

> Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationProvider.cpp:95
> +} // namespace WebKit
> +
>  #endif // ENABLE(GEOLOCATION)

Here the curly brace closing the namespace is inside the ENABLE(GEOLOCATION)
guard, while the initial namespace statement is outside it.