[webkit-reviews] review granted: [Bug 173232] Web Inspector: Don't use -webkit-user-modify CSS property : [Attachment 312697] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 173232: Web Inspector: Don't use -webkit-user-modify CSS property
https://bugs.webkit.org/show_bug.cgi?id=173232

Attachment 312697: Patch

https://bugs.webkit.org/attachment.cgi?id=312697&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 312697
  --> https://bugs.webkit.org/attachment.cgi?id=312697
Patch

r=me

View in context: https://bugs.webkit.org/attachment.cgi?id=312697&action=review

> Source/WebInspectorUI/UserInterface/Views/EditingSupport.js:153
> +	   element.contentEditable = false;

NIT: I think this should be `this.contentEditable = false;` to match the
previous line.

> Source/WebInspectorUI/UserInterface/Views/EditingSupport.js:279
> +	       if (container.parentNode.contentEditable) {

NIT: I think that using the `classList.contains("editing")` is more specific
than just checking for "contentEditable".  I would leave this as it was.

> Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorTreeItem.js:242
> +	   this._mainTitleElement.contentEditable = this.selected ?
"plaintext-only" : false;

NIT: I think this should be moved after the next line to keep consistent
ordering between `this._listItemNode` and `this._mainTitleElement`.