[webkit-reviews] review granted: [Bug 173138] @font-face rules with invalid primary fonts never download their secondary fonts : [Attachment 312611] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 173138: @font-face rules with invalid primary fonts never download their
secondary fonts
https://bugs.webkit.org/show_bug.cgi?id=173138

Attachment 312611: Patch

https://bugs.webkit.org/attachment.cgi?id=312611&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 312611
  --> https://bugs.webkit.org/attachment.cgi?id=312611
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312611&action=review

> Source/WebCore/css/CSSFontFaceSource.cpp:199
> +	   ASSERT(status() == Status::Success);

Is this assertion useful?

> Source/WebCore/css/CSSFontFaceSource.cpp:201
> +	   ASSERT(result);

Is this assertion useful?