[webkit-reviews] review granted: [Bug 173277] [iOS] Cmd-C doesn't copy text from WKWebView : [Attachment 312699] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 12 15:05:52 PDT 2017


mitz at webkit.org has granted Tim Horton <thorton at apple.com>'s request for
review:
Bug 173277: [iOS] Cmd-C doesn't copy text from WKWebView
https://bugs.webkit.org/show_bug.cgi?id=173277

Attachment 312699: Patch

https://bugs.webkit.org/attachment.cgi?id=312699&action=review




--- Comment #3 from mitz at webkit.org ---
Comment on attachment 312699
  --> https://bugs.webkit.org/attachment.cgi?id=312699
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312699&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h:133
> +- (void)_addShortcut:(id)sender;
> +- (void)_arrowKey:(id)sender;
> +- (void)_define:(id)sender;
> +- (void)_lookup:(id)sender;
> +- (void)_reanalyze:(id)sender;
> +- (void)_share:(id)sender;
> +- (void)_showTextStyleOptions:(id)sender;
> +- (void)_promptForReplace:(id)sender;
> +- (void)_transliterateChinese:(id)sender;
> +- (void)replace:(id)sender;

Are these necessary?

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:343
> +

?


More information about the webkit-reviews mailing list