[webkit-reviews] review granted: [Bug 155494] AX: [ATK] Implement missing AtkRelation types : [Attachment 311815] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 12 14:59:15 PDT 2017


Darin Adler <darin at apple.com> has granted Joanmarie Diggs (irc: joanie)
<jdiggs at igalia.com>'s request for review:
Bug 155494: AX: [ATK] Implement missing AtkRelation types
https://bugs.webkit.org/show_bug.cgi?id=155494

Attachment 311815: Patch

https://bugs.webkit.org/attachment.cgi?id=311815&action=review




--- Comment #24 from Darin Adler <darin at apple.com> ---
Comment on attachment 311815
  --> https://bugs.webkit.org/attachment.cgi?id=311815
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311815&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:3303
> +	   if (idList.isEmpty())
> +	       continue;

No need for this optimization; I think SpaceSplitString will handle this fine
without this extra check.


More information about the webkit-reviews mailing list