[webkit-reviews] review granted: [Bug 173269] Seeking an MSE video will begin playing audio long before rendering video : [Attachment 312688] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 173269: Seeking an MSE video will begin playing audio long before rendering
video
https://bugs.webkit.org/show_bug.cgi?id=173269

Attachment 312688: Patch

https://bugs.webkit.org/attachment.cgi?id=312688&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 312688
  --> https://bugs.webkit.org/attachment.cgi?id=312688
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312688&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.m
m:440
> +    if (!CFEqual(kCMSampleBufferConsumerNotification_BufferConsumed,
notificationName))

Nit: kCMSampleBufferConsumerNotification_BufferConsumed should be soft linked.

>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.m
m:983
> +		   CMSetAttachment(sampleCopy.get(),
kCMSampleBufferAttachmentKey_PostNotificationWhenConsumed,
@{kBufferConsumedContext: context.get()},
kCMAttachmentMode_ShouldNotPropagate);

Nit: ditto for kCMSampleBufferAttachmentKey_PostNotificationWhenConsumed.