[webkit-reviews] review denied: [Bug 173195] Use SynchronousLoaderClient for platformLoadResourceSynchronously on WinCairo : [Attachment 312681] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Basuke Suzuki
<Basuke.Suzuki at am.sony.com>'s request for review:
Bug 173195: Use SynchronousLoaderClient for platformLoadResourceSynchronously
on WinCairo
https://bugs.webkit.org/show_bug.cgi?id=173195

Attachment 312681: Patch

https://bugs.webkit.org/attachment.cgi?id=312681&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 312681
  --> https://bugs.webkit.org/attachment.cgi?id=312681
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312681&action=review

Seems like a step in the right direction to match other ports.	Could you use
Tools/Scripts/prepare-ChangeLog to add a ChangeLog entry?

> Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp:130
> +    SynchronousLoaderClient client;
> +    RefPtr<ResourceHandle> handle = adoptRef(new ResourceHandle(context,
request, &client, false, false));
> +    if (!handle)
> +	   return;

null check isn't needed after new in WebKit.  In fact, you could do
Ref<ResourceHandle> handle = adoptRef(*new ResourceHandle(...))