[webkit-reviews] review granted: [Bug 173150] Add API::GeolocationProvider : [Attachment 312677] Rebased patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 12 10:27:34 PDT 2017


Alex Christensen <achristensen at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 173150: Add API::GeolocationProvider
https://bugs.webkit.org/show_bug.cgi?id=173150

Attachment 312677: Rebased patch

https://bugs.webkit.org/attachment.cgi?id=312677&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 312677
  --> https://bugs.webkit.org/attachment.cgi?id=312677
Rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312677&action=review

> Source/WebKit2/UIProcess/WebGeolocationManagerProxy.h:50
> +    void setProvider(std::unique_ptr<API::GeolocationProvider>);

&&

> Source/WebKit2/UIProcess/WebGeolocationProvider.h:44
> +class WebGeolocationProvider : public API::GeolocationProvider, 
API::Client<WKGeolocationProviderBase> {

extra space


More information about the webkit-reviews mailing list