[webkit-reviews] review granted: [Bug 173145] Add API::IconDatabaseClient : [Attachment 312418] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted  review:
Bug 173145: Add API::IconDatabaseClient
https://bugs.webkit.org/show_bug.cgi?id=173145

Attachment 312418: Patch

https://bugs.webkit.org/attachment.cgi?id=312418&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 312418
  --> https://bugs.webkit.org/attachment.cgi?id=312418
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312418&action=review

> Source/WebKit2/UIProcess/API/APIIconDatabaseClient.h:2
> + * Copyright (C) 2014 Apple Inc. All rights reserved.

2017

>>> Source/WebKit2/UIProcess/WebIconDatabase.h:118
>>> +	 std::unique_ptr<API::IconDatabaseClient> m_client;
>> 
>> I think this is wrong.  Usually we have the API object own the WebKit
namespace object.
> 
> Could you point to an example? I think I've followed what all other objects
do. 
> 
>  - WebPageProxy in WebKit namespace owns API::LoaderClient,
API::PolicyClient, API::NavigationClient, and a lot more clients
>  - WebProcessPool in WebKit namespace owns API::AutomationClient,
API::DownloadClient, API::LegacyContextHistoryClient and
API::CustomProtocolManagerClient
> 
> or did I misunderstand what you mean?

After talking to some people, I now think this is correct.  Sorry about the
misunderstanding.  API namespace objects own WebKit namespace objects, but
clients pass calls in the opposite direction.  This is correct.
We should us a UniqueRef here because it's never null.