[webkit-reviews] review denied: [Bug 173261] Retry network process connection if we fail to re-establish it : [Attachment 312657] patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 173261: Retry network process connection if we fail to re-establish it
https://bugs.webkit.org/show_bug.cgi?id=173261

Attachment 312657: patch

https://bugs.webkit.org/attachment.cgi?id=312657&action=review




--- Comment #3 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 312657
  --> https://bugs.webkit.org/attachment.cgi?id=312657
patch

This kind of change worries me.

Adding this somewhat arbitrary "wait 1/4 second, retry 4 times" introduces a
very mysterious behavior to consider and maintain going forward.

Re-establishing the network process connection should succeed the first time.
If it doesn't, that's the bug we should fix.

You mention the problem "might be transient"? Have you shown this patch to
actually produce results in practice?

If so, I think we should be much more interested in why it fails the first
time.