[webkit-reviews] review granted: [Bug 173253] [GCrypt] Use utility functions in CryptoKeyEC, CryptoKeyRSA : [Attachment 312647] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 173253: [GCrypt] Use utility functions in CryptoKeyEC, CryptoKeyRSA
https://bugs.webkit.org/show_bug.cgi?id=173253

Attachment 312647: Patch

https://bugs.webkit.org/attachment.cgi?id=312647&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 312647
  --> https://bugs.webkit.org/attachment.cgi?id=312647
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312647&action=review

Nice!

> Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp:227
> +    return WTFMove(q.value());

Why do you use WTFMove() here? Doesn't this prevent return value optimization?

> Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:70
> +    return WTFMove(data.value());

Ditto.