[webkit-reviews] review granted: [Bug 173153] [CoordinatedGraphics] Behavior change of DrawingAreaImpl after r217779 : [Attachment 312427] patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Daewoong Jang
<daewoong.jang at navercorp.com>'s request for review:
Bug 173153: [CoordinatedGraphics] Behavior change of DrawingAreaImpl after
r217779
https://bugs.webkit.org/show_bug.cgi?id=173153

Attachment 312427: patch

https://bugs.webkit.org/attachment.cgi?id=312427&action=review




--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 312427
  --> https://bugs.webkit.org/attachment.cgi?id=312427
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312427&action=review

> Source/WebKit2/WebProcess/WebPage/AcceleratedDrawingArea.cpp:170
>      if (m_webPage.useFixedLayout()) {
>	   if (m_layerTreeHost)
>	       m_layerTreeHost->sizeDidChange(size);
>	   else if (m_previousLayerTreeHost)
>	       m_previousLayerTreeHost->sizeDidChange(size);

Ok, this comes from CoordinatedDrawingArea, it was merged into
AcceleratedDrawingArea, but never used by us because the DrawingAreaImpl never
chained up. I'm not sure if that was on purpose because this was only used by
the multiprocess coordinated graphics implementation or if it was a bug, but
since we only have threaded coordinated graphics now, I think we can simply
remove this.

> Source/WebKit2/WebProcess/WebPage/AcceleratedDrawingArea.cpp:172
>      m_webPage.mainFrame()->pageOverlayController().didChangeDocumentSize();

And this can be removed too, since FrameView already takes care of this.