[webkit-reviews] review granted: [Bug 173238] [iOS DnD] Allow the injected bundle to add client data when writing an image to the pasteboard : [Attachment 312604] Fix GTK build

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 173238: [iOS DnD] Allow the injected bundle to add client data when writing
an image to the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=173238

Attachment 312604: Fix GTK build

https://bugs.webkit.org/attachment.cgi?id=312604&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 312604
  --> https://bugs.webkit.org/attachment.cgi?id=312604
Fix GTK build

View in context: https://bugs.webkit.org/attachment.cgi?id=312604&action=review

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1431
> +    encoder << types;

We should assert that the size of data & types are the same.

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1433
> +    for (size_t i = 0; i < data.size(); i++)

Why don't we save the size like you did in PlatformPasteboardIOS.mm?