[webkit-reviews] review granted: [Bug 172073] [WTF] Make ThreadMessage portable : [Attachment 312607] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 11 14:11:47 PDT 2017


Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 172073: [WTF] Make ThreadMessage portable
https://bugs.webkit.org/show_bug.cgi?id=172073

Attachment 312607: Patch

https://bugs.webkit.org/attachment.cgi?id=312607&action=review




--- Comment #14 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 312607
  --> https://bugs.webkit.org/attachment.cgi?id=312607
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312607&action=review

r=me with comment.

> Source/WTF/wtf/ThreadingPthreads.cpp:402
> +struct ThreadStateOption {

What's the reasoning behind calling this ThreadStateOption? What do you think
about calling this ThreadStateMetadata?


More information about the webkit-reviews mailing list