[webkit-reviews] review requested: [Bug 158121] Implement W3C Secure Contexts Draft Specification : [Attachment 312606] Part 4: Add runtime enabled feature flag for isSecureContext

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 158121: Implement W3C Secure Contexts Draft Specification
https://bugs.webkit.org/show_bug.cgi?id=158121

Attachment 312606: Part 4: Add runtime enabled feature flag for isSecureContext

https://bugs.webkit.org/attachment.cgi?id=312606&action=review




--- Comment #43 from Daniel Bates <dbates at webkit.org> ---
Created attachment 312606

  --> https://bugs.webkit.org/attachment.cgi?id=312606&action=review

Part 4: Add runtime enabled feature flag for isSecureContext

This patch adds a runtime enabled feature flag to toggle exposing the global
property isSecureContext (defaults: true - expose the property). It also adds a
test to verify that isSecureContext is not exposed (is undefined) when the
runtime enabled feature flag is disabled.

I added a runtime enabled feature flag as opposed to a Setting because the
global property isSecureContext is exposed to Web Workers and Web Workers do
not have access to their associated page's Settings object.