[webkit-reviews] review requested: [Bug 173053] \n\r is not the same as \r\n : [Attachment 312570] proposed patch w/ updated test baselines.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 10 08:58:21 PDT 2017


Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 173053: \n\r is not the same as \r\n
https://bugs.webkit.org/show_bug.cgi?id=173053

Attachment 312570: proposed patch w/ updated test baselines.

https://bugs.webkit.org/attachment.cgi?id=312570&action=review




--- Comment #14 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 312570
  --> https://bugs.webkit.org/attachment.cgi?id=312570
proposed patch w/ updated test baselines.

The patch applies properly: I tested applying it locally on another checkout. 
The EWS patching system just does not like the \r in the patch.  Unfortunately,
the nature of this fix is in the handling of \n\r.  So, I can't remove the use
of \r in the test case.

Let's get the patch reviewed.


More information about the webkit-reviews mailing list