[webkit-reviews] review granted: [Bug 173116] webkitpy: Reduce polling in ServerProcess : [Attachment 312506] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 173116: webkitpy: Reduce polling in ServerProcess
https://bugs.webkit.org/show_bug.cgi?id=173116

Attachment 312506: Patch

https://bugs.webkit.org/attachment.cgi?id=312506&action=review




--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 312506
  --> https://bugs.webkit.org/attachment.cgi?id=312506
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312506&action=review

r=me with one more test case.

> Tools/Scripts/webkitpy/port/driver_unittest.py:147
> +    def test_read_block_crashed_process(self):

We should also add another test for making sure that we don't poll the process
on every line since that's what we're fixing here.