[webkit-reviews] review granted: [Bug 171790] AX: Video/Audio Player Controls missing group container. : [Attachment 312436] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 9 19:04:16 PDT 2017
Antoine Quint <graouts at apple.com> has granted Aaron Chu <aaron_chu at apple.com>'s
request for review:
Bug 171790: AX: Video/Audio Player Controls missing group container.
https://bugs.webkit.org/show_bug.cgi?id=171790
Attachment 312436: Patch
https://bugs.webkit.org/attachment.cgi?id=312436&action=review
--- Comment #15 from Antoine Quint <graouts at apple.com> ---
Comment on attachment 312436
--> https://bugs.webkit.org/attachment.cgi?id=312436
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=312436&action=review
>
Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.js:
245
> + updateBottomControlsBarLabel() {
This should be a private method, please move it down to a Private block and add
a `_` prefix.
More information about the webkit-reviews
mailing list