[webkit-reviews] review granted: [Bug 173185] Web Inspector: REGRESSION(r217749): Event listeners are removed even if they haven't been added : [Attachment 312496] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 9 18:29:25 PDT 2017


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 173185: Web Inspector: REGRESSION(r217749): Event listeners are removed
even if they haven't been added
https://bugs.webkit.org/show_bug.cgi?id=173185

Attachment 312496: Patch

https://bugs.webkit.org/attachment.cgi?id=312496&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 312496
  --> https://bugs.webkit.org/attachment.cgi?id=312496
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312496&action=review

> Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js:94
> +	       this._needsToRemoveResourceEventListeners = false;

Can you also put something up in the constructor that initializes this member
variable.


More information about the webkit-reviews mailing list