[webkit-reviews] review denied: [Bug 173121] Web Inspector: Web inspector does not show non-shadow children of an element with a shadow root (e.g. <video>) : [Attachment 312373] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has denied Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 173121: Web Inspector: Web inspector does not show non-shadow children of
an element with a shadow root (e.g. <video>)
https://bugs.webkit.org/show_bug.cgi?id=173121

Attachment 312373: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=312373&action=review




--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 312373
  --> https://bugs.webkit.org/attachment.cgi?id=312373
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=312373&action=review

>> Source/WebCore/inspector/InspectorDOMAgent.cpp:1370
>> +	    // Always send children if there are ShadowRoots since shadow and
non-shadow children are bundled.
> 
> An alternative solution is to treat actual child nodes and shadow roots more
discretely in the frontend. Currently they are all shared in _children and the
existence of _children affects things. Switching to treating things more
carefully the children can continue to be requested lazily. But this likely
means a lot of places in the frontend will need to change based on how
_children is used. I will look into this alternate solution and see how it
compares to this current solution.
> 
> The approach in this patch could be problematic if the entire tree (or a very
large portion) had nodes with shadow roots, but I don't think that is
realistic.

I think the alternative approach will be simpler and better. I'm going to r-
this.