[webkit-reviews] review granted: [Bug 173174] Make sure we protect |this| in lambdas in WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver() : [Attachment 312466] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 173174: Make sure we protect |this| in lambdas in
WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver()
https://bugs.webkit.org/show_bug.cgi?id=173174

Attachment 312466: Patch

https://bugs.webkit.org/attachment.cgi?id=312466&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 312466
  --> https://bugs.webkit.org/attachment.cgi?id=312466
Patch

Looks good to me.

After this change, though,
WebResourceLoadStatisticsStore::processStatisticsAndDataRecords is the one
remaining lambda that captures [this], but does not ref/deref it. The one
passed to coreStore().processStatistics. Perhaps that function is guaranteed to
run synchronously?