[webkit-reviews] review granted: [Bug 173166] CSS transitions added while page is not visible do not start when the page becomes visible : [Attachment 312452] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 9 10:28:38 PDT 2017
Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 173166: CSS transitions added while page is not visible do not start when
the page becomes visible
https://bugs.webkit.org/show_bug.cgi?id=173166
Attachment 312452: Patch
https://bugs.webkit.org/attachment.cgi?id=312452&action=review
--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 312452
--> https://bugs.webkit.org/attachment.cgi?id=312452
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=312452&action=review
> Source/WebCore/page/animation/CompositeAnimation.cpp:176
> m_transitions.set(prop, WTFMove(implicitAnimation));
Not for this patch, I suppose, but a bit peculiar that this uses set rather
than add.
More information about the webkit-reviews
mailing list