[webkit-reviews] review denied: [Bug 173120] Filter SDP from ICE candidates in case of local ICE candidate filtering : [Attachment 312358] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 9 09:53:04 PDT 2017


Jon Lee <jonlee at apple.com> has denied  review:
Bug 173120: Filter SDP from ICE candidates in case of local ICE candidate
filtering
https://bugs.webkit.org/show_bug.cgi?id=173120

Attachment 312358: Patch

https://bugs.webkit.org/attachment.cgi?id=312358&action=review




--- Comment #6 from Jon Lee <jonlee at apple.com> ---
Comment on attachment 312358
  --> https://bugs.webkit.org/attachment.cgi?id=312358
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312358&action=review

>> LayoutTests/webrtc/datachannel/filter-ice-candidate.html:34
>> +	});
> 
> I'm confused by these tests. Above there are potentially two resolve() calls.
Is that right? Why is filtering set to true in this block, and not set in the
next promise_test(), for parallelism?

It seems that the test isn't reaching some of these asserts. I am able to
change the assertions to clearly wrong conditions, and the test still passes.


More information about the webkit-reviews mailing list