[webkit-reviews] review denied: [Bug 173135] Play button on movie trailers page is cropped with device scale factor 1.25. : [Attachment 312395] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has denied Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 173135: Play button on movie trailers page is cropped with device scale
factor 1.25.
https://bugs.webkit.org/show_bug.cgi?id=173135

Attachment 312395: Patch

https://bugs.webkit.org/attachment.cgi?id=312395&action=review




--- Comment #6 from zalan <zalan at apple.com> ---
Comment on attachment 312395
  --> https://bugs.webkit.org/attachment.cgi?id=312395
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312395&action=review

> Source/WebCore/ChangeLog:10
> +	   Instead of using the function snapSizeToDevicePixel to compute the
bottom, right corder of the
> +	   snapped rectangle, we can use the function roundToDevicePixel.

In the ChangeLog entry you should explain the "why" and not the "what".

> Source/WebCore/ChangeLog:12
> +	   Covered by existing tests. 

It is clearly a behavior change and unless you unksip some test, I don't think
the 'covered by existing tests' is correct. Please add a test case for this
progression.

>> Source/WebCore/platform/graphics/LayoutRect.h:229
>> -	return FloatRect(FloatPoint(roundToDevicePixel(rect.x(),
pixelSnappingFactor), roundToDevicePixel(rect.y(), pixelSnappingFactor)),
snapSizeToDevicePixel(rect.size(), rect.location(), pixelSnappingFactor));
>> +	return FloatRect(FloatPoint(roundToDevicePixel(rect.x(),
pixelSnappingFactor), roundToDevicePixel(rect.y(), pixelSnappingFactor)),
FloatPoint(roundToDevicePixel(rect.maxX(), pixelSnappingFactor),
roundToDevicePixel(rect.maxY(), pixelSnappingFactor)));
> 
> We need Zalan to look at this!

I need to do a bit more digging to figure out if it is correct. in the
meantime, for the reasons above -> r-.