[webkit-reviews] review granted: [Bug 173128] [WebCrypto] Remove unsupported CryptoAlgorithmIdentifier : [Attachment 312379] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 9 08:50:55 PDT 2017


Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 173128: [WebCrypto] Remove unsupported CryptoAlgorithmIdentifier
https://bugs.webkit.org/show_bug.cgi?id=173128

Attachment 312379: Patch

https://bugs.webkit.org/attachment.cgi?id=312379&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 312379
  --> https://bugs.webkit.org/attachment.cgi?id=312379
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312379&action=review

> Source/WebCore/bindings/js/JSCryptoAlgorithmDictionary.cpp:-319
> -    case CryptoAlgorithmIdentifier::AES_CMAC:

When we remove these cases, do we have a general error handler that reports to
the user that it is an unsupported algorithm?

If so, r=me.


More information about the webkit-reviews mailing list