[webkit-reviews] review granted: [Bug 173140] [GTK] Remove WKFullScreenClientGtk : [Attachment 312407] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 173140: [GTK] Remove WKFullScreenClientGtk
https://bugs.webkit.org/show_bug.cgi?id=173140

Attachment 312407: Patch

https://bugs.webkit.org/attachment.cgi?id=312407&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 312407
  --> https://bugs.webkit.org/attachment.cgi?id=312407
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312407&action=review

> Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:311
> +    if (WEBKIT_IS_WEB_VIEW(m_viewWidget))
> +	   webkitWebViewEnterFullScreen(WEBKIT_WEB_VIEW(m_viewWidget));
> +    else
> +	  
webkitWebViewBaseEnterFullScreen(WEBKIT_WEB_VIEW_BASE(m_viewWidget));

What... what could be a WebKitWebViewBase but not a WebKitWebView...?