[webkit-reviews] review granted: [Bug 173123] Crash under -[WKWebView _updateVisibleContentRects] : [Attachment 312362] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 173123: Crash under -[WKWebView _updateVisibleContentRects]
https://bugs.webkit.org/show_bug.cgi?id=173123

Attachment 312362: Patch

https://bugs.webkit.org/attachment.cgi?id=312362&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 312362
  --> https://bugs.webkit.org/attachment.cgi?id=312362
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312362&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:319
> +- (BOOL)_isValid

Maybe adopt this in _webProcessIdentifier and _killWebProcess? This is
definitely better than those, which don't do the nil check.