[webkit-reviews] review denied: [Bug 170203] LayoutTest fast/images/animated-image-different-dest-size.html is a flaky failure : [Attachment 312307] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 8 17:02:17 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 170203: LayoutTest fast/images/animated-image-different-dest-size.html is a
flaky failure
https://bugs.webkit.org/show_bug.cgi?id=170203

Attachment 312307: Patch

https://bugs.webkit.org/attachment.cgi?id=312307&action=review




--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 312307
  --> https://bugs.webkit.org/attachment.cgi?id=312307
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312307&action=review

> LayoutTests/fast/images/animated-image-different-dest-size.html:50
> +	   function loadImage(element, src, canvasIds, frameCount) {
>	       return new Promise((resolve) => {
>		   let image = new Image;
>		   image.onload = (() => {

Now you have an image and an image element. That doesn't make much sense.


More information about the webkit-reviews mailing list