[webkit-reviews] review granted: [Bug 173077] Image should clear its ImageObserver* when CachedImage releases the last reference to its RefCounted<ImageObserver> : [Attachment 312315] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 8 15:29:16 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 173077: Image should clear its ImageObserver* when CachedImage releases the
last reference to its RefCounted<ImageObserver>
https://bugs.webkit.org/show_bug.cgi?id=173077

Attachment 312315: Patch

https://bugs.webkit.org/attachment.cgi?id=312315&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 312315
  --> https://bugs.webkit.org/attachment.cgi?id=312315
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312315&action=review

> Source/WebCore/loader/cache/CachedImage.cpp:375
> +	   if (!m_imageObserver->cachedImages().size()) {

isEmpty()


More information about the webkit-reviews mailing list