[webkit-reviews] Delivery Status Notification (Delay)

Thu Jun 8 14:55:08 PDT 2017

** Delivery incomplete **

There was a temporary problem delivering your message to curtiskwong9 at gmail.com. Gmail will retry for 23 more hours. You'll be notified if the delivery fails permanently.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-reviews/attachments/20170608/066dc0c8/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icon.png
Type: image/png
Size: 3910 bytes
Desc: not available
URL: <http://lists.webkit.org/pipermail/webkit-reviews/attachments/20170608/066dc0c8/attachment-0001.png>
-------------- next part --------------
8;
        Tue, 06 Jun 2017 14:03:31 -0700 (PDT)
ARC-Seal: i=3D1; a=3Drsa-sha256; t=3D1496783011; cv=3Dnone;
        d=3Dgoogle.com; s=3Darc-20160816;
        b=3DV/jA6oybeXPMEm+qcLsPZFcgWbh7nK5JMi6YVBbhJXxHGodUwbneBKvfa+TaElz=
Erk
         EmMlvb5xkDkjNPUp6v/U+Xs20okoN1ISigiooEoUijZtc9vIsmG+608/KYWXAOgsfl=
BH
         rxCFU1D2lkklKMvzyiIQFLrMcdQkbGRdnba2kSgvmS3DTWayNk4CI5pi6B8HdtsdiK=
NG
         mGRGGPl3467TchF/10hNbHP0vt93L8gy3Xx04zd0QQvumW/AIiX1DEnxKV5QRaTjrg=
t9
         wpGE3ztUK7T5BFv5GF1AwldCCTZwvLUz/5XAkvjyjnOnF3WKTwrdf1m2AlnVil5Afk=
An
         ekcg=3D=3D
ARC-Message-Signature: i=3D1; a=3Drsa-sha256; c=3Drelaxed/relaxed; d=3Dgoog=
le.com; s=3Darc-20160816;
        h=3Dlist-subscribe:list-help:list-post:list-archive:list-unsubscrib=
e
         :list-unsubscribe:list-id:precedence:message-id:date:subject:to
         :reply-to:sender:from:content-transfer-encoding:mime-version
         :dkim-signature:delivery-date:arc-authentication-results;
        bh=3DFU2bP6IvrqYgu7sDqnJVX3+3B5vHaRC6T4u2TS1Bp4w=3D;
        b=3Dy4GeX/1MT99bFvGndUmdigL6xfUfr3s8MZGLAFXlGCjJpEi0TUTd+G18n3G4bos=
pcN
         3kAPiXey8SUvVbYTJwf9H+CEK+XrEx4FUZr217jbWaLHTGWwubTbRdLK7V6QbJAmWO=
nw
         raloEuB/q+VQixhwuK/bYpIigTuQhJZVW0p7dCsxPrtuTwswPbox8GerNGYqgdRuhV=
od
         L290iCfEU+mK5XPjgLXFt4o5eFncpPknHn/SY7MC6UNLE44W7SwP/LZa9Wjr3uKnuw=
3F
         RLX7CJRqFKXmjDOoLn1J173zzapFsGur1l8Dy6/7BgDN/gj61+E8L+T/ydLuEnYdGe=
O4
         Sn5Q=3D=3D
ARC-Authentication-Results: i=3D1; mx.google.com;
       dkim=3Dpass header.i=3D at opayq.com;
       spf=3Dpass (google.com: domain of fwd-737r3ysmgfa4ycmac4svaklcefomem=
bmoaqeavriqydcc2lejmyqedaifyycwqcbiblablaqeymcuzuabmyaaiaaea=3D=3D=3D=3D=3D=
=3D at opayq.com designates 184.105.182.159 as permitted sender) smtp.mailfrom=
=3DFWD-737R3YSMGFA4YCMAC4SVAKLCEFOMEMBMOAQEAVRIQYDCC2LEJMYQEDAIFYYCWQCBIBLA=
BLAQEYMCUZUABMYAAIAAEA=3D=3D=3D=3D=3D=3D at opayq.com;
       dmarc=3Dpass (p=3DNONE sp=3DNONE dis=3DNONE) header.from=3Dopayq.com
Return-Path: <FWD-737R3YSMGFA4YCMAC4SVAKLCEFOMEMBMOAQEAVRIQYDCC2LEJMYQEDAIF=
YYCWQCBIBLABLAQEYMCUZUABMYAAIAAEA=3D=3D=3D=3D=3D=3D at opayq.com>
Received: from opayq-out-09.junkemailfilter.com (opayq-out-09.junkemailfilt=
er.com. [184.105.182.159])
        by mx.google.com with ESMTPS id e3si11103260plk.67.2017.06.06.14.03=
.31
        for <curtiskwong9 at gmail.com>
        (version=3DTLS1_2 cipher=3DECDHE-RSA-AES128-GCM-SHA256 bits=3D128/1=
28);
        Tue, 06 Jun 2017 14:03:31 -0700 (PDT)
Received-SPF: pass (google.com: domain of fwd-737r3ysmgfa4ycmac4svaklcefome=
mbmoaqeavriqydcc2lejmyqedaifyycwqcbiblablaqeymcuzuabmyaaiaaea=3D=3D=3D=3D=
=3D=3D at opayq.com designates 184.105.182.159 as permitted sender) client-ip=
=3D184.105.182.159;
Authentication-Results: mx.google.com;
       dkim=3Dpass header.i=3D at opayq.com;
       spf=3Dpass (google.com: domain of fwd-737r3ysmgfa4ycmac4svaklcefomem=
bmoaqeavriqydcc2lejmyqedaifyycwqcbiblablaqeymcuzuabmyaaiaaea=3D=3D=3D=3D=3D=
=3D at opayq.com designates 184.105.182.159 as permitted sender) smtp.mailfrom=
=3DFWD-737R3YSMGFA4YCMAC4SVAKLCEFOMEMBMOAQEAVRIQYDCC2LEJMYQEDAIFYYCWQCBIBLA=
BLAQEYMCUZUABMYAAIAAEA=3D=3D=3D=3D=3D=3D at opayq.com;
       dmarc=3Dpass (p=3DNONE sp=3DNONE dis=3DNONE) header.from=3Dopayq.com
Delivery-date: Tue, 06 Jun 2017 14:03:31 -0700
Received: from smtp2.opayq.com ([54.235.124.91]:9792) helo=3D[54.235.124.91=
]
	by opayq-outbound.junkemailfilter.com with esmtps (TLSv1.2:AES256-SHA256:2=
56)
	(Exim 4.89)
	id 1dILdS-0000JR-KQ on interface=3D184.105.182.150
	for curtiskwong9 at gmail.com; Tue, 06 Jun 2017 14:03:30 -0700
DKIM-Signature: v=3D1; d=3Dopayq.com; t=3D1496783009; b=3DWpagfGmnhhLasRIxX=
hU7Pmrg6IL2suNlrBj6pcrkMlkCdhOm7ZikV3/9Q6kpdgZyQRMtZPA3wbP65GUO/+9+bEa82HhC=
v5MjBepesdvXVlawuIKnu4RBhV5gH+MjH20kzcAZ0LqOE2gLvh15k5kkwNRDquVFucO/noXeU6E=
rUEs=3D; s=3Dabine; c=3Drelaxed/relaxed; a=3Drsa-sha256; bh=3DFU2bP6IvrqYgu=
7sDqnJVX3+3B5vHaRC6T4u2TS1Bp4w=3D; h=3DDate:From:Reply-To:Subject:To:List-U=
nsubscribe;
MIME-Version: 1.0
Content-Type: text/plain; charset=3Dutf-8
Content-Transfer-Encoding: quoted-printable
X-GetAbine-Processed: 1
From: "lists.webkit.org [Masked]" <FWD-737R3YSMGFA4YCMAC4SVAKLCEFOMEMBMOAQE=
AVRIQYDCC2LEJMYQEDAIFYYCWQCBIBLABLAQEYMCUZUABMYAAIAAEA=3D=3D=3D=3D=3D=3D at op=
ayq.com>
Sender: "lists.webkit.org [Masked]" <FWD-737R3YSMGFA4YCMAC4SVAKLCEFOMEMBMOA=
QEAVRIQYDCC2LEJMYQEDAIFYYCWQCBIBLABLAQEYMCUZUABMYAAIAAEA=3D=3D=3D=3D=3D=3D@=
opayq.com>
Reply-To:=20
	FWD-737R3YSMGFA4YCMAC4SVAKLCEFOMEMBMOAQEAVRIQYDCC2LEJMYQEDAIFYYCWQCBIBLABL=
AQEYMCUZUABMYAAIAAEA=3D=3D=3D=3D=3D=3D at opayq.com
To: a61ec514 at opayq.com
X-GetAbine-Sender: webkit-reviews-bounces at lists.webkit.org
X-GetAbine-Disposable: a61ec514 at opayq.com
X-GetAbine-Host-Address: 54.235.124.91
X-AuditID: 11ab0215-fb1bb9a000000cf2-1e-5937188b30b9
Subject: =3D?utf-8?q?webkit-reviews_Digest=3D2C_Vol_145=3D2C_Issue_105?=3D
Date: Tue, 06 Jun 2017 14:03:05 -0700
Message-id: <mailman.2721.1496782985.25281.webkit-reviews at lists.webkit.org>
X-BeenThere: webkit-reviews at lists.webkit.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: WebKit source patch reviews <webkit-reviews.lists.webkit.org>
List-Unsubscribe: <https://lists.webkit.org/mailman/options/webkit-reviews>=
,
 <mailto:webkit-reviews-request at lists.webkit.org?subject=3Dunsubscribe>
List-Unsubscribe: <mailto:unsubscribe-1334138444-a61ec514 at opayq.com>, <http=
s://emails.abine.com/disableDisposable?fwd=3DFWD-737R3YSMGFA4YCMAC4SVAKLCEF=
OMEMBMOAQEAVRIQYDCC2LEJMYQEDAIFYYCWQCBIBLABLAQEYMCUZUABMYAAIAAEA=3D=3D=3D=
=3D=3D=3D at opayq.com>
List-Archive: <http://lists.webkit.org/pipermail/webkit-reviews/>
List-Post: <mailto:webkit-reviews at lists.webkit.org>
List-Help: <mailto:webkit-reviews-request at lists.webkit.org?subject=3Dhelp>
List-Subscribe: <https://lists.webkit.org/mailman/listinfo/webkit-reviews>,
 <mailto:webkit-reviews-request at lists.webkit.org?subject=3Dsubscribe>
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHIsWRmVeSWpSXmKPExsUiON3OVLdHwjzS4=
Np5AYtbdycyWjy81sBm
	sWjKenaLRb2XWCzaunewWHSvCbY4dLXQYkvzV3aL20s+sVtcXvaLxeLfjHXsFqtXbmC0OPL9
	FKtF/5kLjBbX+wUt2pr6WC1+TJe12HDsEItF05blrBa/Hk9it+h+0svoIOox7WcPs8fOWXfZ
	PVb+2s3icfvcVeYAligum5TUnMyy1CJ9uwSujNYZJQUzQiv2Pj7H0sDYENzFyMkhIWAiserz
	bOYuRi4OIYGVTBLTvh9jAknwCghK/Jh8j6WLkYODWUBdYsqUXIiaRiaJl5t+MILE2QR0JeYe
	igUpFxZwkjh8+TgbiC0ioCzx7uk0VhBbSEBTYun6C+wgNouAqkTnniao8d4SZ859YgSxmQUU
	JaYtamCEuEdH4tr0DWwQtqTEvdMPwWwBAQGJeUt2gvXyCLhJrPxyhw3kHh6ByYwSKxfsZYVI
	OErsXXqYHeQ2HgFjib51hhBhD4lZk26wQ9RPYJR4PmcDM0iCVcBI4mvTSkaYB6ZeaWOcwCg+
	C8n7sxDen4Xk1AWMzKsYhXMTM3N0M/OMDPUSCwpyUvWS83M3MYISwGom0R2M818ZHmIU4GBU
	4uEV2GUWKcSaWFZcmXuIUZqDRUmc9+tDo0ghgfTEktTs1NSC1KL4otKc1OJDjEwcnFINjFx3
	9t5Rn6BvXiqVIrPQLMV3u/S7CQu0tuw9asEXVOot/FY98suEx2n8GgsOepQc+NNhlBTX6hr3
	5MT8fa2R+vZxBvdLOn4+nvA6YO+c33y3qx47LfbVOy1741hRDreI6Jo3n4z6CkrVJULPcd57
	/lFCKcb7lfHLv+eOBzguq0l9FZjgsPxquhJLcUaioRZzUXEiAOP5NsHhAgAA
X-Sender-Domain: apple.com
X-Spamfilter-host: plato.junkemailfilter.com - http://www.junkemailfilter.c=
om
X-Key-ID: YTYxZWM1MTRAb3BheXEuY29tIHdlYmtpdC1yZXZpZXdzLWJvdW5jZXNAbGlzdHMud=
2Via2l0Lm9yZyAyMDE3LTA2LTA2IDE0OjAzOjEwIDFkSUxkOC0wMDAxVmUtNkk=3D
X-Content-flags: news voip=20
X-Domain-list: apple.com webkit.org opayq.com
X-Mail-from: webkit-reviews-bounces at lists.webkit.org
X-Relay-Countries: us
X-Sender-Host-Address: 17.171.2.31
X-Sender-Host-Name: mail-out21.apple.com
X-Key-ID: Y3VydGlza3dvbmc5QGdtYWlsLmNvbSBmd2QtNzM3cjN5c21nZmE0eWNtYWM0c3Zha=
2xjZWZvbWVtYm1vYXFlYXZyaXF5ZGNjMmxlam15cWVkYWlmeXljd3FjYmlibGFibGFxZXltY3V6=
dWFibXlhYWlhYWVhPT09PT09QG9wYXlxLmNvbSAyMDE3LTA2LTA2IDE0OjAzOjMwIDFkSUxkUy0=
wMDAwSlItS1E=3D

-------------------------Blur-------------------------
This email is forwarded from a MASKED EMAIL you created using Blur.  (https=
=3D
://dnt.abine.com/#help/faq/faq-whataremaskedemails).
IF THIS IS SPAM, CLICK HERE TO BLOCK:
https://dnt.abine.com/#/block_email/a61ec514@opayq.com/FWD-737R3YSMGFA4YCMA=
=3D
C4SVAKLCEFOMEMBMOAQEAVRIQYDCC2LEJMYQEDAIFYYCWQCBIBLABLAQEYMCUZUABMYAAIAAEA=
=3D
=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D at opayq.com

Want to shop safely and privately online? Go Premium: https://dnt.abine.com=
=3D
/?pk_campaign=3D3DmaskHeader#premium
-------------------------by Abine-------------------------

Send webkit-reviews mailing list submissions to
=3D09webkit-reviews at lists.webkit.org

To subscribe or unsubscribe via the World Wide Web, visit
=3D09https://lists.webkit.org/mailman/listinfo/webkit-reviews
or, via email, send a message with subject or body 'help' to
=3D09webkit-reviews-request at lists.webkit.org

You can reach the person managing the list at
=3D09webkit-reviews-owner at lists.webkit.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of webkit-reviews digest..."

Today's Topics:

   1. review granted: [Bug 170355]
      fast/mediastream/MediaStream-page-muted.html times out and
      asserts : [Attachment 310427] Patch (bugzilla-daemon at webkit.org)
   2. review requested: [Bug 172849] REGRESSION (r199558):
      WKWebView upload file which name contains Chinese character
      results in garbled code : [Attachment 312117] Patch
      (bugzilla-daemon at webkit.org)
   3. review canceled: [Bug 172849] REGRESSION (r199558): WKWebView
      upload file which name contains Chinese character results in
      garbled code : [Attachment 312110] Patch (bugzilla-daemon at webkit.org)
   4. review canceled: [Bug 172504] [macOS][iOS] Temporarily turn
      Subresource Integrity off by default : [Attachment 311020] Patch
      (bugzilla-daemon at webkit.org)
   5. review granted: [Bug 172263]
      AudioSourceProviderAVFObjC::m_tap member access is not thread
      safe. : [Attachment 310493] Patch (bugzilla-daemon at webkit.org)
   6. review canceled: [Bug 172940] webkitpy: Return correct
      process names from SimulatorProcess : [Attachment 312037] Patch
      (bugzilla-daemon at webkit.org)

----------------------------------------------------------------------

Message: 1
Date: Tue, 06 Jun 2017 20:44:30 +0000
From: bugzilla-daemon at webkit.org
To: webkit-reviews at lists.webkit.org
Subject: [webkit-reviews] review granted: [Bug 170355]
=3D09fast/mediastream/MediaStream-page-muted.html times out and asserts :
=3D09[Attachment 310427] Patch
Message-ID: <bug-170355-0-BAn2PPjo6l at https.bugs.webkit.org/>
Content-Type: text/plain; charset=3D3D"UTF-8"

Darin Adler <darin at apple.com> has granted Per Arne Vollan <pvollan at apple.co=
=3D
m>'s
request for review:
Bug 170355: fast/mediastream/MediaStream-page-muted.html times out and asse=
=3D
rts
https://bugs.webkit.org/show_bug.cgi?id=3D3D170355

Attachment 310427: Patch

https://bugs.webkit.org/attachment.cgi?id=3D3D310427&action=3D3Dreview

--- Comment #16 from Darin Adler <darin at apple.com> ---
Comment on attachment 310427
  --> https://bugs.webkit.org/attachment.cgi?id=3D3D310427
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=3D3D310427&actio=
n=3D
=3D3Dreview

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:343
> +    if (!ended())
> +=3D09   return true;
> +    return ActiveDOMObject::hasPendingActivity();

Looks OK like this. Could also just write this:

    return !ended() || ActiveDOMObject::hasPendingActivity();

I find that form quite readable for a simple case like this, maybe more tha=
=3D
n
the early exit style.

> Source/WebCore/Modules/mediastream/MediaStreamTrack.h:125
> +    // ActiveDOMObject API.
> +    bool hasPendingActivity() const final;

I suggest making this override private rather than public. I also don=3DE2=
=3D80=3D
=3D99t think
we need the "ActiveDOMObject API" comment. For one thing, an interface like
this inside WebCore is not "API".

------------------------------

Mes
----- Message truncated -----