[webkit-reviews] review granted: [Bug 173085] Crash inside InsertNodeBeforeCommand via InsertParagraphSeparatorCommand : [Attachment 312271] Updated the change log
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 8 14:54:50 PDT 2017
Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 173085: Crash inside InsertNodeBeforeCommand via
InsertParagraphSeparatorCommand
https://bugs.webkit.org/show_bug.cgi?id=173085
Attachment 312271: Updated the change log
https://bugs.webkit.org/attachment.cgi?id=312271&action=review
--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 312271
--> https://bugs.webkit.org/attachment.cgi?id=312271
Updated the change log
View in context: https://bugs.webkit.org/attachment.cgi?id=312271&action=review
> Source/WebCore/ChangeLog:5
> +
Is there a radar link we can include?
> Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp:198
> + if (visiblePos.isNull())
Nit - Can we move this to right after we create visiblePos, so we don't have to
calculateStyleBeforeInsertion() unnecessarily in the case that
visiblePos.isNull()?
More information about the webkit-reviews
mailing list