[webkit-reviews] review granted: [Bug 173094] [GTK] Get rid of custom marshallers of signals : [Attachment 312293] Patch

[bugzilla-daemon at webkit.org]

Zan Dobersek <zan at falconsigh.net> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 173094: [GTK] Get rid of custom marshallers of signals
https://bugs.webkit.org/show_bug.cgi?id=173094

Attachment 312293: Patch

https://bugs.webkit.org/attachment.cgi?id=312293&action=review




--- Comment #4 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 312293
  --> https://bugs.webkit.org/attachment.cgi?id=312293
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312293&action=review

>>> Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardList.cpp:87
>>> +	     g_cclosure_marshal_generic,
>> 
>> You could as well pass “nullptr” here. According to the documentation for
“g_signal_new()”
>>
(https://developer.gnome.org/gobject/stable/gobject-Signals.html#g-signal-new):
> 
> g_signal_new is already difficult to read with severl 0, nullptr, nullptr. In
some cases we even add a comment explaining what the nullptr/0 is. So, I prefer
to pass the marshaller for readability.

SGTM. Let's be explicit where possible.