[webkit-reviews] review granted: [Bug 173088] WebAssembly: We should only create wrappers for functions that can be exported : [Attachment 312277] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 173088: WebAssembly: We should only create wrappers for functions that can
be exported
https://bugs.webkit.org/show_bug.cgi?id=173088

Attachment 312277: Patch

https://bugs.webkit.org/attachment.cgi?id=312277&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 312277
  --> https://bugs.webkit.org/attachment.cgi?id=312277
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312277&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +	   can actually be exported. It appears to be a ~2.5% speedup on
WasmBench.

nice

> Source/JavaScriptCore/ChangeLog:11
> +	   This patch also removes most of the old testWasmModuleFunctions api
from the jsc CLI.

🎉

Also, why "most" here? It looks like you're removing it all

> Tools/Scripts/run-jsc-stress-tests:1204
> +    if !$quickMode

Do you want to give the specTests/Emscripten the same treatment?