[webkit-reviews] review granted: [Bug 165977] WebAssembly: test imports and exports with 16-bit characters : [Attachment 312256] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 7 17:22:33 PDT 2017
Saam Barati <sbarati at apple.com> has granted JF Bastien <jfbastien at apple.com>'s
request for review:
Bug 165977: WebAssembly: test imports and exports with 16-bit characters
https://bugs.webkit.org/show_bug.cgi?id=165977
Attachment 312256: patch
https://bugs.webkit.org/attachment.cgi?id=312256&action=review
--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 312256
--> https://bugs.webkit.org/attachment.cgi?id=312256
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=312256&action=review
r=me
> Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.cpp:141
> + return before + String(" ") + String::fromUTF8(import.module) + ":"
+ String::fromUTF8(import.field) + " " + after;
you should use makeString here
More information about the webkit-reviews
mailing list