[webkit-reviews] review granted: [Bug 173079] Add a borderless mode to <attachment>, and make it respect its layout size : [Attachment 312246] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 173079: Add a borderless mode to <attachment>, and make it respect its
layout size
https://bugs.webkit.org/show_bug.cgi?id=173079

Attachment 312246: Patch

https://bugs.webkit.org/attachment.cgi?id=312246&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 312246
  --> https://bugs.webkit.org/attachment.cgi?id=312246
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312246&action=review

> Source/WebCore/rendering/RenderAttachment.cpp:77
> +    if (style().appearance() == BorderlessAttachmentPart)
> +	   return false;
> +    return m_shouldDrawBorder;

Can m_shouldDrawBorder just be set to false for this type of attachment?