[webkit-reviews] review denied: [Bug 173070] webkitpy: By default, OutputCaptureScope should capture all output which would be printed : [Attachment 312247] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 173070: webkitpy: By default, OutputCaptureScope should capture all output
which would be printed
https://bugs.webkit.org/show_bug.cgi?id=173070

Attachment 312247: Patch

https://bugs.webkit.org/attachment.cgi?id=312247&action=review




--- Comment #8 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 312247
  --> https://bugs.webkit.org/attachment.cgi?id=312247
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312247&action=review

> Tools/Scripts/webkitpy/common/system/outputcapture.py:116
> +	   if not self._output_capture:
> +	       self._output_capture = OutputCapture()
> +	       self._output_capture.set_log_level(logging.getLogger().level)

I feel this is more surprising not less surprising. OuputCaptureScope should
just be a context-manager for OutputCapture. I am not a fan that it
instantiates an OutputCapture as a convenience though we did it. Given that it
OutputCaptureScope instantiate an OutputCapture it is surprising that when
OuputCaptureScope does this that it alters the default log level of the
OutputCapture it instantiates.