[webkit-reviews] review denied: [Bug 173070] webkitpy: By default, OutputCaptureScope should capture all output which would be printed : [Attachment 312218] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 173070: webkitpy: By default, OutputCaptureScope should capture all output
which would be printed
https://bugs.webkit.org/show_bug.cgi?id=173070

Attachment 312218: Patch

https://bugs.webkit.org/attachment.cgi?id=312218&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 312218
  --> https://bugs.webkit.org/attachment.cgi?id=312218
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312218&action=review

> Tools/Scripts/webkitpy/common/system/outputcapture.py:115
> +	   if self._output_capture:
> +	       self._output_capture = OutputCapture()

r- because of this. We are overriding the specified output_capture object.

> Tools/Scripts/webkitpy/common/system/outputcapture.py:116
> +	       self._output_capture.set_log_level(logging.getLogger().level)

It does not seem appropriate for this class to chose the log level to capture
given that this class takes an OutputCapture object. The caller should
instantiate an OutputCapture o, set the appropriate log level, and then pass o
to OutputCaptureScope.