[webkit-reviews] review granted: [Bug 172487] Web Inspector: Allow user to choose stylesheet when creating new rules : [Attachment 311359] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 172487: Web Inspector: Allow user to choose stylesheet when creating new
rules
https://bugs.webkit.org/show_bug.cgi?id=172487

Attachment 311359: Patch

https://bugs.webkit.org/attachment.cgi?id=311359&action=review




--- Comment #10 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 311359
  --> https://bugs.webkit.org/attachment.cgi?id=311359
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311359&action=review

> LayoutTests/inspector/css/add-rule-expected.txt:8
> +PASS: The selector is "body"
> +PASS: The range is [0:0,0:4]
> +PASS: The origin is "inspector"

These could all be converted to `should be` sentences. Something like:

    PASS: Rule selector should be "body".
    PASS: Rule range should be [0:0,0:4].
    PASS: Rule origin should be "inspector".

> LayoutTests/inspector/css/add-rule.html:142
> +	       CSSAgent.addRule("-1", "div", ruleAdded);

Same thing about an obviously bad identifier. "DOES_NOT_EXIST" or
"BAD_IDENTIFIER" etc.