[webkit-reviews] review granted: [Bug 173062] Laili restaurant menu page does not display full menu in Safari (works in Chrome and Firefox) : [Attachment 312217] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 173062: Laili restaurant menu page does not display full menu in Safari
(works in Chrome and Firefox)
https://bugs.webkit.org/show_bug.cgi?id=173062

Attachment 312217: Patch

https://bugs.webkit.org/attachment.cgi?id=312217&action=review




--- Comment #14 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 312217
  --> https://bugs.webkit.org/attachment.cgi?id=312217
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312217&action=review

> Source/WebCore/ChangeLog:11
> +	   properly. min-max-height were not handled properly though and need
to do the same check.

Say something about iBooks here?

Can we test the iBooks behavior?

> Source/WebCore/rendering/RenderBox.cpp:3130
> +static bool isRequestFromIBooks()

This should be called useReplacePercentageHeightAutoContainerQuirk() or
something.

There should be a comment with a radar number, for a radar on iBooks that
tracks their fixing the content to not need this quirk in future.

> Source/WebCore/rendering/RenderBox.cpp:3155
> +	   return isRequestFromIBooks() ? false :
cb->hasAutoHeightOrContainingBlockWithAutoHeight();

You can return false before this block for iBooks, since both return values are
false here and below.